Discussion XBlock: Bundle up all JS files with webpack#155
Discussion XBlock: Bundle up all JS files with webpack#155salman2013 wants to merge 2 commits intosalman/extract-discussion-blockfrom
Conversation
openedx-webhooks
added
open-source-contribution
|
Thanks for the pull request, @salman2013! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
salman2013
force-pushed
the
salman/discussion-block-webpack
branch
from
5f460f1 to
636c16c
Compare
salman2013
added
the
create-sandbox
salman2013
removed
the
create-sandbox
2 participants
Description:
In this PR we bundled all discussion block's JS files into one JS file with webpack. Load the bundled file with resource url method which will optimized the files loading in browser.
Ticket: openedx/public-engineering#480
Testing Results:
Note: These screenshots are the testing results on local environment.